lib: add process.loadedModules list - #61330
Conversation
|
Review requested:
|
nodejs-github-bot
added
lib / src
Add a new `process.loadedModules` property that returns an array of public core module names that have been loaded during the current Node.js process execution. This provides a cleaner, documented API for accessing loaded module information compared to the undocumented `process.moduleLoadList`. Fixes: nodejs#41233 Refs: nodejs#61276
8530bcb to
afe4f56
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61330 +/- ##
==========================================
+ Coverage 88.00% 89.67% +1.66%
==========================================
Files 704 676 -28
Lines 208739 206481 -2258
Branches 40196 39536 -660
==========================================
+ Hits 183706 185161 +1455
+ Misses 16992 13465 -3527
+ Partials 8041 7855 -186
🚀 New features to boost your workflow:
|
| require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| assert.ok(Array.isArray(process.loadedModules)); |
There was a problem hiding this comment.
I think there should be a little more on what's in that is actually what it should be :)
There was a problem hiding this comment.
Is it a better now? I'm not willing to test exact values in there to avoid flacky tests, am I wrong?
| if (!StringPrototypeStartsWith(id, 'internal/')) { | ||
| ArrayPrototypePush(loadedModules, id); | ||
| } |
There was a problem hiding this comment.
Does this handle #61276 (comment) and #61276 (comment) from Joyee had on your previous doc PR?
I think it specifically doesn't handle:
the names of the modules are also highly volatile and cannot be reliably depended on
There was a problem hiding this comment.
I may have misunderstood Joyee's feedback, but I tought the internal/ prefix to be somehow reliable as it's almost as old as Node.js itself. Can you think of something else? :/
|
This pull request has been marked as stale due to 90 days of inactivity. |
3 participants
Add a new
process.loadedModulesproperty that returns an array of public core module names that have been loaded during the current Node.js process execution. This provides a cleaner, documented API for accessing loaded module information compared to the undocumentedprocess.moduleLoadList.Fixes: #41233
Refs: #61276